I was reviewing some PowerShell script today and it was absolutely atrocious. It's only saving grace was that it was using actual PowerShell, not some hacky wmic call or anything.
I didn't write it and I'm really glad for that. Whole lines of rewritten code commented out and just left there. Entire lines of # marks. There's no reason this should be so densely commented. Your code should be self explanatory.
There were multiple queries to the same database that was then passed through a "where-object" selector by pipe, looking for a single value (pulling a database of thousands of entries for one line).
It was disgusting.
I'm not even a developer and I thought it was horrid.
I was reviewing some PowerShell script today and it was absolutely atrocious. It's only saving grace was that it was using actual PowerShell, not some hacky wmic call or anything.
I didn't write it and I'm really glad for that. Whole lines of rewritten code commented out and just left there. Entire lines of # marks. There's no reason this should be so densely commented. Your code should be self explanatory.
There were multiple queries to the same database that was then passed through a "where-object" selector by pipe, looking for a single value (pulling a database of thousands of entries for one line).
It was disgusting.
I'm not even a developer and I thought it was horrid.